Re: st: foreach and forvalues combined

[William Buchanan <william@williambuchanan.net>]

Have you tried replacing the first line with:

forv i = 1/5{

You don't need a foreach loop here if you're just interested in looping over the values of a categorical variable.

HTH,
Billy

Sent from my iPhone

On Jul 4, 2012, at 7:02, "Fabian Schönenberger" <sch.f@gmx.ch> wrote:

> Dear Statalist
> 
> I am facing the following challenge with my panel data while trying the form different portfolios (double ranking with size and BM-ratio). After generating the variable sizebm5 with: 
> 
> generate sizebmp5=11 if bm<bm4 & sizep5==1 & timeyear==1975
> 
> I want to loop the conditions sizep5== and timeyear==. Sizep5 is a variable consisting of numbers from 1 to 5 (1 small companies, 5 large companies). Timeyear is the time variable, 1975 to 2012. I am trying the following:
> 
> 
> . foreach i of sizep5 1/5 {
>  2. forvalues t = 1975/2012 {
>  3. replace sizebmp5=1`i' if bm<bm4 & sizep5==`i' & timeyear==`t'
>  4. }
>  5. }
> 
> However Stata says invalid syntax. I guess the problem is with sizebmp5=1`i' -> 1 stands for the first condition bm<bm4 (I will change this condition manually and then switch to 2 and so on). With `i' I want the variable signalling the corresponding sizep5 portfolio. Because this variable changes from 1 to 5, I need the term `i'; I also tried 1_`i' but it did not work. 
> 
> Any suggestions to solve this problem?
> 
> Many thanks in advance.
> 
> Thx, Fabian 
> 
> *
> *   For searches and help try:
> *   http://www.stata.com/help.cgi?search
> *   http://www.stata.com/support/statalist/faq
> *   http://www.ats.ucla.edu/stat/stata/

*
*   For searches and help try:
*   http://www.stata.com/help.cgi?search
*   http://www.stata.com/support/statalist/faq
*   http://www.ats.ucla.edu/stat/stata/